Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The disconnect from the signal was not passing the this reference as it was used in the connect, hence the disconnect failed to find the handler.
When developing a theia based app we run into leaks due to TabsMainImpl keeping our custom control
in memory even when it was closed. The leak was through the controls title, through TabsMainImpl.
This PR fixes the main issue, which was leaking every control for us.
However the TabsMainImpl still is not optimal as it only releases references when it rebuilds its model,
and that does not happen when closing a tab.